Skip to content

Incorrect input pressure units for the Python refraction models #5

Description

@AdamRJensen

For the refraction models in the Python package, I think the units should be hPa as reported in the paper and not Pa as shown in the documentation.
https://github.com/gschwind/sg2/blob/ca99a3ac35454ae85a4b2ec02c231c5bdebf2aa3/python/pysg2.cxx#L1046-L047

The Python functions are sg2.topocentric_correction_refraction_SAE and sg2.topocentric_correction_refraction_ZIM.

ICYMI @IoannisSifnaios and @kandersolar

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions