Skip to content

fix: simplify voiceOver.navigateToWebContent() now auto-navigation is disabled by default #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmorten merged 2 commits into from
Aug 16, 2026
Merged

fix: simplify voiceOver.navigateToWebContent() now auto-navigation is disabled by default #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e3992
fix: move away from move to top due to flakiness now that auto-naviga…
cmorten Aug 15, 2026
0dd7ff1
fix: don't cancel on interaction to ensure VO bootstraps on an intera…
cmorten Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions src/screenReaderTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ export const screenReaderTest = test.extend<{
// Ensure application is brought to front and focused.
await macOSActivate(applicationName);

// Cancel auto navigation.
// Cancel automatic behaviours/previous commands.
await screenReaderPlaywright.perform(
{ keyCode: MacOSKeyCodes.Control },
{ capture: false },
Expand Down Expand Up @@ -326,28 +326,6 @@ export const screenReaderTest = test.extend<{
await screenReaderPlaywright.interact({ capture: false });
await delay(100);

// Navigate to the beginning of the web content.
await screenReaderPlaywright.perform(
voiceOverKeyCodeCommands.moveToBeginningOfText,
{ capture: false },
);
await delay(100);

// Cancel auto navigation
await screenReaderPlaywright.perform(
{ keyCode: MacOSKeyCodes.Control },
{ capture: false },
);
await delay(100);

// Navigate to the Guidepup marker element at beginning of the web
// content.
await screenReaderPlaywright.perform(
voiceOverKeyCodeCommands.moveToBeginningOfText,
{ capture: false },
);
await delay(100);

// Navigate to the first element of the page using the provided
// capture settings.
await screenReaderPlaywright.next({ capture });
Expand Down
24 changes: 1 addition & 23 deletions src/voiceOverTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export const voiceOverTest = test.extend<{
// Ensure application is brought to front and focused.
await macOSActivate(applicationName);

// Cancel auto navigation.
// Cancel automatic behaviours/previous commands.
await voiceOverPlaywright.perform(
{ keyCode: MacOSKeyCodes.Control },
{ capture: false },
Expand Down Expand Up @@ -161,28 +161,6 @@ export const voiceOverTest = test.extend<{
await voiceOverPlaywright.interact({ capture: false });
await delay(100);

// Navigate to the beginning of the web content.
await voiceOverPlaywright.perform(
voiceOverPlaywright.keyboardCommands.moveToBeginningOfText,
{ capture: false },
);
await delay(100);

// Cancel auto navigation
await voiceOverPlaywright.perform(
{ keyCode: MacOSKeyCodes.Control },
{ capture: false },
);
await delay(100);

// Navigate to the Guidepup marker element at beginning of the web
// content.
await voiceOverPlaywright.perform(
voiceOverPlaywright.keyboardCommands.moveToBeginningOfText,
{ capture: false },
);
await delay(100);

// Navigate to the first element of the page using the provided
// capture settings.
await voiceOverPlaywright.next({ capture });
Expand Down
Loading