Fix CMake config mode package finding - #129
Open
jnhyatt wants to merge 1 commit into
Open
Conversation
Owner
|
Sorry, I didn't react for so long. Was pretty occupied lately. I'll look into it and do some tests. As this will change the project file names for IDEs like Xcode or Visual Studio, I would put this into a new minor version, so the upcoming version will be a v1.6.0 I guess. |
Contributor
|
We just ran into this in Fedora Linux. Is this still planned for a 1.6.0 release somewhere in the indefinite future? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a recent build, I realized that find_package was unable to find ghcfilesystem with it installed in my CMake prefix path (on Windows). After some poking around, I nailed it down to the final install directory not matching any of the search patterns in CMake's config mode package finder search procedure. The directory
ghc_filesystem-config.cmakeshould be in must look like one of these in order to be found without special tweaks to the package find procedure:Because the project name was ghcfilesystem, the default path was
<prefix-path>/ghcfilesystem/lib/cmake/ghc_filesystem/ghc_filesystem-config.cmake(missing underscore). This problem likely doesn't manifest on Linux due to the way amake installworks. Once I fixed the project name, CMake find_package was able to find the package with no problems.