fix: resolve relative targets in Windows copy_symlink() - #212
Open
hannahgreendesk wants to merge 2 commits into
Open
fix: resolve relative targets in Windows copy_symlink()#212hannahgreendesk wants to merge 2 commits into
hannahgreendesk wants to merge 2 commits into
Conversation
Signed-off-by: hannahgreendesk <hannahgreendesk@users.noreply.github.com>
Signed-off-by: hannahgreendesk <hannahgreendesk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows,
copy_symlink()classifies the new link as a file or directory symlink by probing the stored target path. Relative targets were resolved against the process working directory, so an unrelated cwd entry (or a missing one) could pick the wrong link type.Resolve relative targets against the source symlink's parent for that lookup only. The text stored in the source link is still passed unchanged to
create_symlink/create_directory_symlink.Test plan
fs.op.copy_symlinkwith a nested relative directory symlink copy case (nested/slink→"dir").Fixes #211