Add GlutinSurface::new_gl33_with_builders
#564
Conversation
|
So your new function doesn’t set the actual context? It relies on the client setting it, right? That’s not super sound, it’s super easy to mess up and forget which context to use. |
| ) -> Result<Self, GlutinError> { | ||
| let windowed_ctx = context_builder.build_windowed(window_builder, &event_loop)?; | ||
|
|
||
| let ctx = unsafe { windowed_ctx.make_current().map_err(|(_, e)| e)? }; |
There was a problem hiding this comment.
The new function sets the context here. Not sure what you mean in your comment.
There was a problem hiding this comment.
I mean, the OpenGL 3.3 context. Here if the cliente doesn’t call the right function .with_gl etc.), it will not work as intended.
There was a problem hiding this comment.
Well, if you'd like, you can override the code's choice by calling .with_gl(GlRequest::Specific(Api::OpenGl, (3, 3))).with_gl_profile(GlProfile::Core) on the passed-in builder, but as it stands, it's impossible to set other useful options on the context, like vsync or srgb, or use an event loop with a generic type, because luminance needlessly takes control over those parts of the code.
There was a problem hiding this comment.
So an example of creating a GLFW window, people don’t have to think about it.
There was a problem hiding this comment.
I've updated the PR to set the context version and profile explicitly, and rebased to master.
ColonelThirtyTwo
force-pushed
the
glutin-with-event-loop
branch
from
ce6ff87 to
82abd96
Compare
ColonelThirtyTwo
force-pushed
the
glutin-with-event-loop
branch
2 times, most recently
from
8c51f5e to
99a3615
Compare
This is a constructor of `GlutinSurface` that allows the `EventLoop`, `WindowBuilder`, and `ContextBuilder` to be passed in and thus configured by the user (In particular, the existing constructors do not allow passing in an `EventLoop`). To ensure the context matches what luminance needs, the context is forced to OpenGL version 3.3 core profile.
ColonelThirtyTwo
force-pushed
the
glutin-with-event-loop
branch
from
99a3615 to
b478683
Compare
2 participants
This is a constructor of
GlutinSurfacethat allows theEventLoop,WindowBuilder, andContextBuilderto be passed in and thus configured by the user (In particular, the existing constructors do not allow passing in anEventLoop).