Skip to content

Enable different tax_reason_text per tax #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable different tax_reason_text per tax #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/secretariat/invoice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def errors
@errors
end

def tax_reason_text
tax_reason || TAX_EXEMPTION_REASONS[tax_category]
def tax_reason_text(tax)
tax_reason || TAX_EXEMPTION_REASONS[tax.tax_category || tax_category]
end

def tax_category_code(tax, version: 2)
Expand Down Expand Up @@ -283,8 +283,8 @@ def to_xml(version: 1, validate: true)
xml['ram'].ApplicableTradeTax do
Helpers.currency_element(xml, 'ram', 'CalculatedAmount', tax.tax_amount, currency_code, add_currency: version == 1)
xml['ram'].TypeCode 'VAT'
if tax_reason_text.present?
xml['ram'].ExemptionReason tax_reason_text
if tax_reason_text(tax).present?
xml['ram'].ExemptionReason tax_reason_text(tax)
end
Helpers.currency_element(xml, 'ram', 'BasisAmount', tax.base_amount, currency_code, add_currency: version == 1)
xml['ram'].CategoryCode tax_category_code(tax, version: version)
Expand Down