Move tcpdi_parser to package #71
Conversation
vitormattos
changed the title
|
Hi @hanneskod can you help to check if all is ok on this PR? |
|
Hi, Any updates on this? |
|
I'm follow using my fork |
|
Looking at code I remembered that I stopped to use this package after a lot of problems on scenario that I need to use merging PDF from different sources. I started to use mikehaertl/php-pdftk and this solved all problems about merge PDF |
| matrix: | ||
| coverage: ['xdebug'] | ||
| xdebug_mode: ['debug'] | ||
| php-versions: ['7.3', '7.4', '8.0', '8.1'] |
There was a problem hiding this comment.
| php-versions: ['7.3', '7.4', '8.0', '8.1'] | |
| php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2' ,'8.3', '8.4', '8.5'] |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| php-versions: ['7.3', '7.4', '8.0', '8.1'] |
There was a problem hiding this comment.
| php-versions: ['7.3', '7.4', '8.0', '8.1'] | |
| php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2' ,'8.3', '8.4', '8.5'] |
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
@kaystrobach Can you merge this one ?
Maybe applying my comments with the button could be great
|
I plan to take a look. Needs proper testing though. Will take some time. @hanneskod would you be fine with me tagging releases? If so i would like to tag one before this change and a BC one after that change. |
4 participants
Review first #69
Close #64
I merged all fixes to
tcpdi_parseron this PR and the changes of libmergepdf ontcpdi_parsertoo.