Merge AfterHighlight into autoload and remove plugin checks.#9
Open
pynappo wants to merge 2 commits intohardhackerlabs:mainfrom
Open
Merge AfterHighlight into autoload and remove plugin checks.#9pynappo wants to merge 2 commits intohardhackerlabs:mainfrom
AfterHighlight into autoload and remove plugin checks.#9pynappo wants to merge 2 commits intohardhackerlabs:mainfrom
Conversation
People will lazy-load plugins so the luaeval checks may return a misleading result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most colorschemes set plugin-specific highlights regardless of whether the plugins are loaded. Also, from my understanding, using after/plugin here is unnecessary - well-written plugins won't override colorscheme colors.
I have moved and modified the code from
AfterHighlight()intoautoload/hardhacker.vimto adopt the same convention as other colorschemes.This is meant to fix #8. Let me know if this breaks anything, thanks.