Show extra info for Skipped (include XFailed) cases #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsun
force-pushed
the
mark_e2e_known_issues
branch
from
0306396 to
1ea2e30
Compare
albinsun
changed the title
albinsun
force-pushed
the
mark_e2e_known_issues
branch
7 times, most recently
from
85644f0 to
6895359
Compare
albinsun
changed the title
albinsun
force-pushed
the
mark_e2e_known_issues
branch
2 times, most recently
from
11ea0c5 to
dca47fb
Compare
Signed-off-by: Albin Sun <[email protected]>
albinsun
force-pushed
the
mark_e2e_known_issues
branch
from
dca47fb to
a972aa9
Compare
albinsun
changed the title
jbrockmeyer
approved these changes
Jan 7, 2026
khushboo-rancher
approved these changes
Jan 7, 2026
lanfon72
approved these changes
Jan 7, 2026
| reason.format(cluster_version=cluster_ver, versions=versions) | ||
| reason.format( | ||
| cluster_version=cluster_ver, | ||
| condition=cond_str.get(cond, str(cond)), |
Member
There was a problem hiding this comment.
We didn’t restrict the condition parameter to only any or all; instead, we allowed any callable function. As a result, it may fail if a user provides other callable functions.
To prevent this, we can simply use callable.__name__ to retrieve the condition name, which also eliminates the need to maintain a mapping table.
| delete_image(api_client, exported_image_id, wait_timeout) | ||
|
|
||
| @pytest.mark.skip_version_if( | ||
| ">= v1.7.0", "< v1.9.0", reason="https://github.com/harvester/harvester/issues/9515") |
Member
There was a problem hiding this comment.
#9515 has been rescheduled to v1.9.0.
I would suggest to add regression in reason and not limit the before version, then when then issue be fixed, we can use the keyword to search and update the skip restriction.
And it would be helpful that add the test case path when filing the regression issue. (cc @asc5543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #2373
What this PR does / why we need it:
pytest.mark.skip_version_*marks to the more explicitpytest.mark.skip_version_if.skip_version_if()if the milestone is decided. For those still inPlanning, may usexfail(expected fail) temporarily.Special notes for your reviewer:
For known issue to leverage this enhancement, skip
reasonshould contain URL.Additional documentation or context
Verification (
harvester-install-and-test#9)