Skip to content

Conversation

@flipyap
Copy link
Contributor

@flipyap flipyap commented Aug 26, 2024

Adding an "oldest_create_index" node selector to the list of selectors to help with behaviors similar to that of the default AWS scaling strategy.

@tgross
Copy link
Member

tgross commented Sep 23, 2024

Hi @flipyap! We're going to take a look at this soon!

(Internal ref: https://hashicorp.atlassian.net/browse/NET-10944)

@tgross tgross self-requested a review September 27, 2024 14:36
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flipyap! I've left some minor comments but otherwise this looks great! Can you add a line to the CHANGELOG.md as well?

Once this ships, I'll follow-up with a docs PR here in the main Nomad repo.

@tgross tgross self-assigned this Sep 27, 2024
@flipyap
Copy link
Contributor Author

flipyap commented Sep 30, 2024

Hi @flipyap! I've left some minor comments but otherwise this looks great! Can you add a line to the CHANGELOG.md as well?

Once this ships, I'll follow-up with a docs PR here in the main Nomad repo.

Done! Thank you!

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @flipyap!

I've resolved merge conflicts with the changelog via the Github UI because you don't have edits enabled on your branch. Once CI is green I'll merge this.

@tgross tgross merged commit a13c1d8 into hashicorp:main Oct 1, 2024
19 checks passed
@flipyap
Copy link
Contributor Author

flipyap commented Oct 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants