Skip to content

fix issue #61 nil pointer dereference #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #61 nil pointer dereference #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,17 +330,18 @@ func (a *Autopilot) adjudicateRemoval(ids []raft.ServerID, vr *voterRegistry) []
for _, id := range ids {
v := vr.eligibility[id]

if v != nil && v.isPotentialVoter() && initialPotentialVoters-removedPotentialVoters-1 < int(minQuorum) {
a.logger.Debug("will not remove server node as it would leave less voters than the minimum number allowed", "id", id, "min", minQuorum)
} else if v.isCurrentVoter() && maxRemoval < 1 {
a.logger.Debug("will not remove server node as removal of a majority of voting servers is not safe", "id", id)
} else if v != nil && v.isPotentialVoter() {
switch {
case v != nil && v.isPotentialVoter() && initialPotentialVoters-removedPotentialVoters-1 < int(minQuorum):
a.logger.Debug("will not remove server node as it would leave less voters than the minimum number allowed",
"id", id, "min", minQuorum)
case v != nil && v.isCurrentVoter() && maxRemoval < 1:
a.logger.Debug("will not remove server node as removal of a majority of voting servers is not safe",
"id", id)
case v != nil && v.isPotentialVoter():
maxRemoval--
// We need to track how many voters we have removed from the registry
// to ensure the total remaining potential voters is accurate
removedPotentialVoters++
result = append(result, id)
} else {
default:
result = append(result, id)
}
}
Expand Down