VAULT-40584 reference opt-in new list evaluation for denied_params in old versions #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@schavis assuming stuff looks good this should only be merged when the next minor version goes out right (tentative date Nov 19), as it'll update the live docs correct? |
Contributor
Vercel Previews Deployed
|
Contributor
Broken Link CheckerNo broken links found! 🎉 |
Contributor
Yes, merging to |
schavis
requested changes
Nov 5, 2025
Comment on lines
+580
to
+583
| Vault 1.21.x or later defaults to a more intuitive list processing for | ||
| `allowed_parameters` and `denied_parameters`. In Vault 1.16, this new behavior can | ||
| be enabled starting on 1.16.28 by setting the environment variable | ||
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Vault 1.21.x or later defaults to a more intuitive list processing for | |
| `allowed_parameters` and `denied_parameters`. In Vault 1.16, this new behavior can | |
| be enabled starting on 1.16.28 by setting the environment variable | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. | |
| Vault 1.21.x introduced a more intuitive list processing for `allowed_parameters` | |
| and `denied_parameters`. You can enable the intuitive list processing behavior | |
| for Vault 1.16.x by upgrading to 1.16.28 or later and setting the | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST` environment variable. |
Style correction: avoid "this" as a pronoun
Comment on lines
+587
to
+590
| Vault 1.21.x or later defaults to a more intuitive list processing for | ||
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | ||
| be enabled starting on 1.19.12 by setting the environment variable | ||
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Vault 1.21.x or later defaults to a more intuitive list processing for | |
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | |
| be enabled starting on 1.19.12 by setting the environment variable | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. | |
| Vault 1.21.x introduced a more intuitive list processing for `allowed_parameters` | |
| and `denied_parameters`. You can enable the intuitive list processing behavior | |
| for Vault by upgrading to Vault 1.19.12 or later and setting the | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST` environment variable. |
Edited to use language similar to 1.16
Contributor
There was a problem hiding this comment.
Is there a reason we recommend moving to 1.19 instead of upgrading to 1.21? I'm assuming it's because 1.18 to 1.19 is a simpler upgrade path, but wanted to confirm.
Comment on lines
+587
to
+590
| Vault 1.21.x or later defaults to a more intuitive list processing for | ||
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | ||
| be enabled starting on 1.19.12 by setting the environment variable | ||
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Vault 1.21.x or later defaults to a more intuitive list processing for | |
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | |
| be enabled starting on 1.19.12 by setting the environment variable | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. | |
| Vault 1.21.x introduced a more intuitive list processing for `allowed_parameters` | |
| and `denied_parameters`. You can enable the intuitive list processing behavior | |
| for Vault by upgrading to Vault 1.19.12 or later and setting the | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST` environment variable. |
Edited to use language similar to 1.16
Contributor
There was a problem hiding this comment.
Same comment re: upgrade path here
Comment on lines
+587
to
+590
| Vault 1.21.x or later defaults to a more intuitive list processing for | ||
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | ||
| be enabled starting on 1.19.12 by setting the environment variable | ||
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Vault 1.21.x or later defaults to a more intuitive list processing for | |
| `allowed_parameters` and `denied_parameters`. In Vault 1.19, this new behavior can | |
| be enabled starting on 1.19.12 by setting the environment variable | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. | |
| Vault 1.21.x introduced a more intuitive list processing for `allowed_parameters` | |
| and `denied_parameters`. You can enable the intuitive list processing behavior | |
| for Vault 1.19.x by upgrading to 1.19.12 or later and setting the | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST` environment variable. |
Edited to use language similar to 1.16
Comment on lines
+589
to
+592
| Vault 1.21.x or later defaults to a more intuitive list processing for | ||
| `allowed_parameters` and `denied_parameters`. In Vault 1.20, this new behavior can | ||
| be enabled starting on 1.20.6 by setting the environment variable | ||
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Vault 1.21.x or later defaults to a more intuitive list processing for | |
| `allowed_parameters` and `denied_parameters`. In Vault 1.20, this new behavior can | |
| be enabled starting on 1.20.6 by setting the environment variable | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST`. | |
| Vault 1.21.x introduced a more intuitive list processing for `allowed_parameters` | |
| and `denied_parameters`. You can enable the intuitive list processing behavior | |
| for Vault 1.20.x by upgrading to 1.20.6 or later and setting the | |
| `VAULT_NEW_PER_ELEMENT_MATCHING_ON_LIST` environment variable. |
Edited to use language similar to 1.16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docs added in #1191 in order to reference a new environment variable
VAULT_NEW_PER_ELEMENT_MATCHING_ON_LISTthat will allow customers on the old (still-supported and ent-only) versions 1.20.6, 1.19.12 and 1.16.28 to have access to the new evaluation behavior.I made different recommendations on the upgrade tip for each of the versions:
Jira: VAULT-40584