-
Notifications
You must be signed in to change notification settings - Fork 112
Nomad Docs: Add new QEMU driver parameters #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nomad/1.11.1
Are you sure you want to change the base?
Conversation
Vercel Previews Deployed
|
Broken Link CheckerNo broken links found! 🎉 |
aimeeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a few style guide suggestions.
content/nomad/v1.11.x/content/docs/job-declare/task-driver/qemu.mdx
Outdated
Show resolved
Hide resolved
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config, | ||
| and `fingerprint_emulator` was added to the driver config. These default to the | ||
| previously used values of `qemu-system-x86_64`, and `pc`. Previously, when using | ||
| the `kvm` accelerator, the machine type `host` was forced. This is no longer true, | ||
| the value for `machine_type` will be used. Additionally, if using resources.cores, | ||
| with the `kvm` accelerator, the `-smp` was hardcoded to that number of cores. This | ||
| is now only done if the user has not specified a custom -smp flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config, | |
| and `fingerprint_emulator` was added to the driver config. These default to the | |
| previously used values of `qemu-system-x86_64`, and `pc`. Previously, when using | |
| the `kvm` accelerator, the machine type `host` was forced. This is no longer true, | |
| the value for `machine_type` will be used. Additionally, if using resources.cores, | |
| with the `kvm` accelerator, the `-smp` was hardcoded to that number of cores. This | |
| is now only done if the user has not specified a custom -smp flag. | |
| In Nomad 1.11.1, we added `emulator` and `machine_type` to the task config and | |
| `fingerprint_emulator` to the driver config. These default to the previously | |
| used values of `qemu-system-x86_64` and `pc`. Previously, when using the `kvm` | |
| accelerator, Nomad forced the machine type `host`. This is no longer true. Nomad | |
| now uses the value for `machine_type` . Additionally, if using `resources.cores` | |
| with the `kvm` accelerator, the `-smp` used that number of cores. Nomad now only | |
| uses the `resources.cores` value when you have not specified a custom `-smp` | |
| flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to refactor this paragraph a good bit after refactoring my PR
aimeeu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some style guide suggestions. Let me know if you'd like me to apply them directly.
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config. | ||
| These default to the previously used values of `qemu-system-x86_64`, and `pc`. | ||
| The `emulators_allowlist` driver config was also added, which defaults to | ||
| allowing any emulator to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In Nomad 1.11.1, `emulator` and `machine_type` were added to the task config. | |
| These default to the previously used values of `qemu-system-x86_64`, and `pc`. | |
| The `emulators_allowlist` driver config was also added, which defaults to | |
| allowing any emulator to run. | |
| In Nomad 1.11.1, we added `emulator` and `machine_type` to the task config. | |
| These default to the previously used values of `qemu-system-x86_64`, and `pc`. | |
| We also added the `emulators_allowlist` driver config, which defaults to | |
| allowing any emulator to run. |
style update to use active voice
| Previously, when using the `kvm` accelerator the machine type `host` was required. | ||
| This is no longer enforced. The value for `machine_type` will be used. Also, if using | ||
| resources.cores with the `kvm` accelerator, the `-smp` was hardcoded to resources.cores | ||
| value. This is now only done if the user has not specified a custom -smp flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Previously, when using the `kvm` accelerator the machine type `host` was required. | |
| This is no longer enforced. The value for `machine_type` will be used. Also, if using | |
| resources.cores with the `kvm` accelerator, the `-smp` was hardcoded to resources.cores | |
| value. This is now only done if the user has not specified a custom -smp flag. | |
| Previously, using the `kvm` accelerator required a machine type of `host`. This | |
| is no longer enforced. Nomad now uses the value for `machine_type`. Also, if | |
| using `resources.cores` with the `kvm` accelerator, Nomad set the `-smp` value | |
| to the `resources.cores` value. Nomad now only does this when you do not specify | |
| a custom `-smp` flag. |
Style updates to use present tense and active voice.
| - `driver.qemu` - Set to `1` if QEMU is found on the host node. Nomad determines | ||
| this by executing `qemu-system-x86_64 -version` on the host and parsing the output | ||
| - `driver.qemu.version` - Version of `qemu-system-x86_64`, ex: `2.4.0` | ||
| this by executing the first found qemu binary with `--version` on the client and | ||
| parsing the output. Nomad does not get the version of each individual qemu emulator. | ||
| - `driver.qemu.version` - Version found running the command for `driver.qemu`, ex: `2.4.0` | ||
| - `driver.qemu.emulators` - A comma separated list of emulators detected on the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - `driver.qemu` - Set to `1` if QEMU is found on the host node. Nomad determines | |
| this by executing `qemu-system-x86_64 -version` on the host and parsing the output | |
| - `driver.qemu.version` - Version of `qemu-system-x86_64`, ex: `2.4.0` | |
| this by executing the first found qemu binary with `--version` on the client and | |
| parsing the output. Nomad does not get the version of each individual qemu emulator. | |
| - `driver.qemu.version` - Version found running the command for `driver.qemu`, ex: `2.4.0` | |
| - `driver.qemu.emulators` - A comma separated list of emulators detected on the client. | |
| - `driver.qemu` - Set to `1` if QEMU is found on the host node. Nomad determines | |
| this by executing the first found QEMU binary with `--version` on the client | |
| and parsing the output. Nomad does not get the version of each individual QEMU | |
| emulator. | |
| - `driver.qemu.version` - Version found running the command for `driver.qemu`, | |
| ex: `2.4.0` | |
| - `driver.qemu.emulators` - A comma separated list of emulators detected on the | |
| client. |
| - `emulators_allowlist` (`[]string`: `[]`) - Specifies the allowed emulators | ||
| tasks may use. When specified Nomad will only fingerprint this list, and | ||
| will not allow tasks to run using other emulators. Defaults to fingerprinting | ||
| and allowing all emulators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - `emulators_allowlist` (`[]string`: `[]`) - Specifies the allowed emulators | |
| tasks may use. When specified Nomad will only fingerprint this list, and | |
| will not allow tasks to run using other emulators. Defaults to fingerprinting | |
| and allowing all emulators. | |
| - `emulators_allowlist` (`[]string`: `[]`) - Specifies the allowed emulators | |
| tasks may use. When specified, Nomad only fingerprints this list and does not | |
| allow tasks to run using other emulators. Defaults to fingerprinting and | |
| allowing all emulators. |
| The `qemu` driver can execute any regular `qemu` image (e.g. `qcow`, `img`, | ||
| `iso`), and is currently invoked with `qemu-system-x86_64`. | ||
| `iso`). Nomad uses the QEMU binary specified by the `emulator` | ||
| parameter (ex. If `x86_64` is specified, Nomad will use `qemu-system-x86_64`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| parameter (ex. If `x86_64` is specified, Nomad will use `qemu-system-x86_64`). | |
| parameter (ex. If `x86_64` is specified, Nomad uses `qemu-system-x86_64`). |
style update to use present tense
| be the name of the image. However, if the supplied artifact is an archive that | ||
| contains the image in a subfolder, the path will need to be the relative path | ||
| (`subdir/from_archive/my.img`). | ||
| (`subdir/from_archive/my.img`). This image is given an ID of "image0". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (`subdir/from_archive/my.img`). This image is given an ID of "image0". | |
| (`subdir/from_archive/my.img`). Nomad give this image an ID of "image0". |
style update to use active voice
Description
Links
Code PR: hashicorp/nomad#27179
Contributor checklists
Review urgency:
Pull request:
Content:
Reviewer checklist