Swap transformCaretLower and transformCaretUpper#11491
Swap transformCaretLower and transformCaretUpper#11491mergify[bot] merged 1 commit intohaskell:masterfrom
Conversation
22b9481 to
7f98c7b
Compare
|
@Mikolaj and @geekosaur, bootstrap jobs are timing out. They work locally for me. |
82937a1 to
48911d7
Compare
|
It looks like a network and/or Hackage outage. Let me restart anyway... |
|
... and it worked! :) |
|
Thanks @Mikolaj. I restarted the failing bootstrap jobs 3 times before I asked. Good to see it working again. |
|
Documentation is great, but as I mentioned in #11490 (comment) I think the implementations should not be swapped. |
|
TBH that's why I've been keeping quiet about this PR; not being familiar with the exact usage of these functions, I suspected but wasn't sure if that was the intent. |
2927fc4 to
e10897d
Compare
@Bodigrim, I've undone the swap. |
- Swap transformCaretLower and transformCaretUpper - Add haddock modification subsection - Add a bit more explanation of caret bounds. - Change the examples for transformCaretUpper, including the zeroes case - Avoid long word-wrapping subsection title - Undo swap of transformCaret[Upper <-> Lower]
e10897d to
4e98d4f
Compare
Merge Queue StatusRule:
This pull request spent 1 hour 53 minutes 42 seconds in the queue, including 1 hour 42 minutes 57 seconds running CI. Required conditions to merge
|
Related to #11490 but only adds more explanation and doctest examples for the caret version transforming functions. Add subsections to the modification section, range-preserving and range-relaxing modifications.
Note
I find the function names,
transformCaretUpperandtransformCaretLower, a bit generic and would have preferredremoveCaretUpperandremoveCaretLower. There are alreadyremoveUpperBoundandremoveLowerBoundfunctions.QA Notes
For running doctests locally:
For building the haddocks locally: