Repository navigation
Conversation
ChristophHochrainer
requested review from
fendor and
michaelpj
as code owners
October 10, 2026 12:19
VeryMilkyJoe
force-pushed
the
feat/5114-add-support-for-file-creation
branch
3 times, most recently
from
October 11, 2026 12:34
393f6ca to
14ac0b5
Compare
fendor
approved these changes
Oct 11, 2026
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Great work, this is some amazing progress!
fendor
force-pushed
the
feat/5114-add-support-for-file-creation
branch
from
October 14, 2026 09:19
5db9d4b to
40c94e1
Compare
fendor
enabled auto-merge (squash)
October 14, 2026 09:20
fendor
force-pushed
the
feat/5114-add-support-for-file-creation
branch
from
October 14, 2026 09:55
40c94e1 to
d4d1fc8
Compare
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the mentioned file creation hook for the
CabalAddmodule of thecabalplugin mentioned in #5114.The feature creates a best guess of an automatic module placement in the nearest cabal file.
Currently, if a new file is created, the name of the file is assumed as the module name.
Then HLS proposes an edit to the closest cabal file in either
other-modules(default) orexposed-modules(only for main libraries).If the module name is already in use, no action is taken.
The implementation is strongly inspired by the already present
Renameimplementation.Tests
The test architecture as well as the plugin request system is copied and slightly adapted from the
Renamefeature.The tests cover most of the component types as well as the negative case of a module with the same name present.
Open Tasks
From the issue #5114, I have not created the
didCreateFilesuggestion with the module header.I believe this can be another issue as this PR is already quite big.