Repository navigation
refactor: enforce braces, two-param functions and 200-line files - #31
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
helderberto
force-pushed
the
refactor/structure-4-views
branch
from
October 24, 2026 10:54
385b394 to
52658e4
Compare
ESLint now fails on one-line ifs (curly), functions with more than two parameters (max-params) and files over 200 lines (max-lines). The command palette's result list and the resume experience move to their own files to fit, each with tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZqAJbwwPeQSQFaPLDDSfr
helderberto
force-pushed
the
refactor/structure-5-lint
branch
from
October 24, 2026 10:55
4b8afb3 to
e504986
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part 5 of 7, based on part 4. Puts the code rules (no inline ifs, at most two parameters, files under 200 lines) in ESLint so they hold without review.
Summary
src/**/*.{ts,tsx}:curly: all,max-params: 2,max-lines: 200(blank lines and comments skipped). Ten inline ifs get braces via--fix; no function had more than two parameters.palette-list.tsx: the palette's result list as its own component, same markup and CSS module.command-palette.test.tsx(rendering, opening, closing) andcommand-palette.search.test.tsx(search, keyboard, selection), sharingcommand-palette.test-utils.tsx.resume-experience.ts: the experience list leavesresume-data.ts(was 244 lines), with tests that jobs and positions are listed newest first.Evidence
Merge danger
Door: two-way
Blast radius: lint config
Generated by Claude Code