Conversation
matthyx
force-pushed
the
fix/url-decode-asset-filenames
branch
from
November 21, 2025 13:09
1c72bf2 to
b0c0bf7
Compare
Author
|
@cpanato can you have a look please? |
Fixes helm#281 Decode the asset filename in addToIndexFile before accessing the local chart package so SemVer build metadata encoded as %2B resolves to +. UpdateIndexFile already uses the decoded URL.Path and needs no extra unescaping. Add a regression test for an encoded plus sign and verify that the index preserves the chart version's build metadata. Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
matthyx
force-pushed
the
fix/url-decode-asset-filenames
branch
from
September 11, 2026 14:52
b0c0bf7 to
eb67bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart packages with SemVer build metadata fail during indexing when GitHub encodes
+as%2Bin the asset URL: chart-releaser looks fortest-chart-0.1.0%2Bbuild.1.tgzinstead of the localtest-chart-0.1.0+build.1.tgz.Decode the asset filename in
addToIndexFile()before accessing the local chart package.UpdateIndexFile()already reads the decodedurl.URL.Path, so it requires no additional unescaping. The regression test verifies that the encoded asset URL resolves correctly and the index preserves version0.1.0+build.1; its fake embeds the existing GitHub fake to support the current interface.Closes #281.
Validation:
GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1 go test ./... -race -count=1passes. Git configuration is isolated because a local HTTPS-to-SSH rewrite breaks the existingTestGit_GetPushURLtest.go vet ./...,golangci-lint run --timeout 5m, formatting checks, andgit diff --checkpass.