feat: make recipe cards interactive with detail page and Run Match - #353
Merged
Conversation
Recipe cards were static text with no way to view a recipe or match it, unlike design cards. Add a RecipeDetailView (mirroring OkhDetailView) at the existing okh/:id route for the cooking domain, link each recipe card to it, and give both the card and the detail page a Run Match action that preselects the recipe on the match page via ?recipe_id=. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecipeDetailView(mirroringOkhDetailView's breadcrumb/title/actions layout) rendered at the existingokh/:idroute whendomain=cooking, reusing the already-cached["recipes"]query since there's no per-recipe fetch endpoint./match?recipe_id=<id>.MatchPage/CookingMatchViewnow readrecipe_idfrom the URL and preselect it inRecipePicker, mirroring howokh_idpreselects a design on the hardware match page.Test plan
npm run typechecknpm run lint(no new warnings/errors on touched files)npm run test:unit— 346/346 passing, including new tests forRecipeListView,RecipeDetailView, andCookingMatchView'sinitialRecipeIdpreselectMade with Cursor