Skip to content

popm: fix TestDisconnectedOpgeth #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2025
Merged

popm: fix TestDisconnectedOpgeth #739

merged 6 commits into from
Nov 11, 2025

Conversation

@AL-CT
Copy link
Contributor

@AL-CT AL-CT commented Nov 3, 2025

Summary
Fixes the test TestDisconnectedOpgeth, as detailed in #718.

The test was run 100 times to ensure its viability: https://github.com/hemilabs/heminetwork/actions/runs/19041422367/job/54379408025

Changes

  • Fixed a locking issue when closing websocket connections.
  • Closing the connections did not necessarily prevent requests from being handled within a for loop, so added an exit condition when server is closed.
  • Refactored the test to prevent other possible edge-cases and improve logging.

@AL-CT AL-CT requested a review from a team as a code owner November 3, 2025 16:48
@github-actions github-actions bot added area: popm This is a change to popm (PoP Miner) changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Nov 3, 2025
@AL-CT AL-CT added changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors). and removed changelog: required This pull request must update the CHANGELOG.md file or explicitly be marked with changelog: skip labels Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/testutil/mock/mock.go 0.00% 5 Missing ⚠️
internal/testutil/mock/tbc.go 0.00% 5 Missing ⚠️
internal/testutil/mock/geth.go 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

marcopeereboom
marcopeereboom approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@marcopeereboom marcopeereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yas!

@AL-CT AL-CT requested a review from a team November 6, 2025 16:06
joshuasing
joshuasing requested changes Nov 10, 2025
View reviewed changes
@AL-CT AL-CT force-pushed the toni/disconnected_test_fix branch from 35b54fe to 6527ecd Compare November 10, 2025 18:42
@AL-CT AL-CT merged commit 70eaa53 into main Nov 11, 2025
9 of 10 checks passed
@AL-CT AL-CT deleted the toni/disconnected_test_fix branch November 11, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcopeereboom marcopeereboom marcopeereboom approved these changes

@joshuasing joshuasing joshuasing approved these changes

Assignees

No one assigned

Labels

area: popm This is a change to popm (PoP Miner) changelog: skip This pull request does not require a changelog entry (e.g. tests, docs, CI, minor refactors).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AL-CT @marcopeereboom @joshuasing