fix(windows): add local cmd installer bootstrap - #3133
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Windows installer now supports a ChangesWindows installation fallback
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The Windows CMD fallback may leave install.cmd in the working directory when installation fails, creating minor cleanup burden for affected users. The PR is otherwise mergeable with explicit owner awareness or follow-up to clean up the file on failure. Sequence Diagram(s)sequenceDiagram
participant CommandPrompt
participant install.cmd
participant install.ps1
participant curl.exe
CommandPrompt->>install.cmd: download and run bootstrap
install.cmd->>curl.exe: download install.ps1
install.cmd->>install.ps1: forward installer arguments
install.ps1->>curl.exe: download manifest and package
curl.exe-->>install.ps1: return downloaded files
install.ps1-->>install.cmd: return installer exit code
install.cmd-->>CommandPrompt: remove temporary file and return exit code
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kangal-bot
added
the
ai-review
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 78561173-7f43-4cfd-9a35-823506e725cd
📒 Files selected for processing (24)
README.mdREADME.zh-CN.mddocs/next/CHANGELOG.mddocs/next/README.mddocs/next/README.zh-CN.mddocs/next/website/src/content/docs/install.mdxdocs/next/website/src/content/docs/ja/install.mdxdocs/next/website/src/content/docs/ja/windows-beta.mdxdocs/next/website/src/content/docs/windows-beta.mdxdocs/next/website/src/content/docs/zh-cn/install.mdxdocs/next/website/src/content/docs/zh-cn/windows-beta.mdxdocs/versions/0.8.2/website/src/content/docs/install.mdxdocs/versions/0.8.2/website/src/content/docs/ja/install.mdxdocs/versions/0.8.2/website/src/content/docs/ja/windows-beta.mdxdocs/versions/0.8.2/website/src/content/docs/windows-beta.mdxdocs/versions/0.8.2/website/src/content/docs/zh-cn/install.mdxdocs/versions/0.8.2/website/src/content/docs/zh-cn/windows-beta.mdxscripts/windows_install_conpty_package_test.ps1website/_headerswebsite/agent-guide.mdwebsite/index.htmlwebsite/install.cmdwebsite/install.ps1website/scripts/prepare-docs.mjs
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: aafe2bbb-149b-4e0a-8ceb-0d144aa37cfc
📒 Files selected for processing (4)
README.zh-CN.mddocs/next/README.zh-CN.mdwebsite/install.cmdwebsite/install.ps1
🚧 Files skipped from review as they are similar to previous changes (2)
- README.zh-CN.md
- docs/next/README.zh-CN.md
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.
Greptile SummaryThe PR adds a locally downloaded Command Prompt bootstrap for Windows environments that block fileless PowerShell execution.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| website/install.cmd | Adds the local CMD bootstrap, propagates installer arguments and exit status, and removes its temporary PowerShell script. |
| website/install.ps1 | Uses a bounded curl-based helper for manifest and package downloads while preserving validation and checksum enforcement. |
| scripts/windows_install_conpty_package_test.ps1 | Extends Windows installer integration coverage to invoke the CMD bootstrap and verify a successful stable installation. |
| website/scripts/prepare-docs.mjs | Copies the new CMD bootstrap into the website's public build assets. |
| website/_headers | Configures the public CMD installer endpoint to be served as inline plain text. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Command Prompt user] --> B[Download install.cmd over HTTPS]
B --> C[install.cmd downloads install.ps1 to TEMP]
C --> D[PowerShell runs local install.ps1]
D --> E[Download release manifest]
E --> F[Select Windows package]
F --> G[Download package]
G --> H[Verify SHA-256 and package layout]
H --> I[Activate versioned release]
I --> J[Delete temporary installer]
Reviews (3): Last reviewed commit: "fix(windows): bound installer downloads" | Re-trigger Greptile
63f08be to
c21b919
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a1cca11f-4169-4cf2-aefd-81482f257749
📒 Files selected for processing (2)
docs/next/CHANGELOG.mdwebsite/install.cmd
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/next/CHANGELOG.md
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.
c21b919 to
e1b9ba3
Compare
kangal-bot
removed
the
ai-review
2 participants
Summary
irm https://herdr.dev/install.ps1 | iexinstall commandinstall.cmdlocally for endpoint-protected environmentscurl.exefor installer manifest and package downloads while preserving SHA-256 verificationinstall.cmdwith the website and document the fallback in current and next-release Windows docsWhy
Cortex XDR can block the fileless
irm | iexprocess shape before Herdr's PowerShell installer runs. A local script launched withpowershell.exe -Fileavoids that behavior without replacing the familiar public install command.Validation
just checkinstall.cmdmatches the source assetCortex XDR confirmation still requires the issue reporter's environment.
Refs #2751