Skip to content

fix(action): enforce truthful quality-gate outcomes - #20

Merged
roli-lpci merged 1 commit into
mainfrom
codex/pyg-mp-003-truthful-outcome-20260817
Aug 17, 2026
Merged

fix(action): enforce truthful quality-gate outcomes#20
roli-lpci merged 1 commit into
mainfrom
codex/pyg-mp-003-truthful-outcome-20260817

Conversation

@roli-lpci

Copy link
Copy Markdown
Collaborator

Summary

  • add fail-on-error, defaulting to truthful quality-gate failure behavior
  • preserve status, failures-json, and repair-status outputs
  • distinguish quality-gate/repair outcomes from command or input infrastructure errors
  • exercise pass-default, fail-default, and fail-observation behavior in the clean-consumer smoke matrix

Scope

This is PYG-MP-003 only. It does not change repair/comment defaults, changed-file discovery, dependencies, documentation, or the separately queued hidden-artifact uploader defect.

Verification

  • actionlint passed
  • Ruff and format checks passed
  • Python 3.12.13: 158 passed
  • deterministic manifest/workflow/output/SHA-pin assertions passed
  • final-outcome truth table: 11/11
  • gate/repair exit classification: 9/9
  • exact two-file diff and diff hygiene passed

The PR's live clean-consumer matrix is the remaining proof for the three public action-step outcomes. Live repair escalation remains unevaluated; its final-step behavior is covered statically without inventing unreliable repair behavior.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@roli-lpci, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Limit details: You’ve used all 3 included reviews currently available under your plan.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e99bf8b-3419-4e21-9bd5-2b308cfe96bf

📥 Commits

Reviewing files that changed from the base of the PR and between 5414e6a and 2339c9c.

📒 Files selected for processing (2)
  • .github/workflows/action-smoke.yml
  • action.yml

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

PyGate Quality Gate Results

PyGate Agent Brief — run_20260817195618_d34dc071

Mode: canary
Status: fail
Summary: 6 deterministic finding(s) require repair.

Findings & Actions

pyright_reportReturnType_tests/action-fixture/fail.py_2

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/action-fixture/fail.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

pyright_reportMissingImports_tests/conftest.py_6

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/conftest.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

pyright_reportMissingImports_tests/test_cli.py_6

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/test_cli.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

pyright_reportMissingImports_tests/test_edge_cases.py_14

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/test_edge_cases.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

pyright_reportMissingImports_tests/test_models.py_5

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/test_models.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

pyright_reportMissingModuleSource_tests/test_primitive_contract.py_10

  • Action: Resolve Pyright type errors for impacted files and re-run typecheck.
  • Scope: single_file
  • Files: tests/test_primitive_contract.py
  • Rationale: typecheck failed deterministically. Address this before any inferred optimizations.

Retry Policy

  • Max attempts: 3
  • Max patch lines: 150
  • Abort on no improvement: 2 consecutive attempts

Escalation

  • Required: True
  • Reason: UNRESOLVED_DETERMINISTIC_FAILURES
  • Message: Escalate with evidence packet if bounded repair loop cannot clear deterministic failures.

@roli-lpci
roli-lpci merged commit 346a77a into main Aug 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant