Skip to content

Apply Hermes Gate checkout credential correction - #43

Merged
roli-lpci merged 1 commit into
mainfrom
fix/hermes-gate-v014-rail
Sep 10, 2026
Merged

roli-lpci merged 1 commit into
mainfrom
fix/hermes-gate-v014-rail

Conversation

@roli-lpci

@roli-lpci roli-lpci commented Sep 10, 2026

Copy link
Copy Markdown
Member

Apply the checkout credential correction from Hermes Gate v0.1.4 to this existing generated quality rail: set persist-credentials: false on its checkout step. The current runner has no base-selection interface, so it is unaffected by the separate empty-base defect.

Validation: the diff is confined to the checkout setting; Hermes Gate fast and committed-head semantic review pass. Source correction and regression evidence: hermes-labs-ai/hermes-gate#7.

Summary by CodeRabbit

  • Chores
    • Updated the quality-check workflow to avoid persisting repository credentials during checkout.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 15d8cb51-b26a-497f-b6a6-d36b20575291

📥 Commits

Reviewing files that changed from the base of the PR and between 845a301 and ceccb31.

📒 Files selected for processing (1)
  • .github/workflows/hermes-quality.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Hermes quality workflow now disables Git credential persistence in the full job's checkout step.

Changes

Workflow credential handling

Layer / File(s) Summary
Disable checkout credential persistence
.github/workflows/hermes-quality.yml
The actions/checkout step sets persist-credentials: false.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ceccb

The Hermes quality workflow no longer retains checkout credentials for later job steps. The focused configuration change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Hermes Gate checkout credential correction, which matches the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hermes-gate-v014-rail

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@roli-lpci
roli-lpci merged commit b5b2ee6 into main Sep 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant