Skip to content

refactor: move Kubernetes events to dedicated package - #1408

Open
lukasmetzner wants to merge 3 commits into
mainfrom
refactor/events-package
Open

lukasmetzner wants to merge 3 commits into
mainfrom
refactor/events-package

Conversation

@lukasmetzner

Copy link
Copy Markdown
Member

Moves Kubernetes event handling into a new internal/events package. events.Recorder wraps record.EventRecorder and writes each event to klog as a structured log with kind, object, type, and reason. Event reasons are now typed events.Reason constants.

In a follow-up PR docs are added to each constant describing the trigger for the event and if suited, how to mitigate it.

@lukasmetzner
lukasmetzner requested a review from a team as a code owner October 30, 2026 14:52
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.61905% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.63%. Comparing base (5686d34) to head (35e9af4).

Files with missing lines Patch % Lines
internal/testsupport/events.go 0.00% 11 Missing ⚠️
internal/hcops/load_balancer.go 75.00% 7 Missing ⚠️
internal/instance/instances.go 66.66% 4 Missing ⚠️
internal/testenv/testenv.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   74.84%   74.63%   -0.21%     
==========================================
  Files          33       34       +1     
  Lines        2544     2551       +7     
==========================================
  Hits         1904     1904              
- Misses        640      647       +7     
Flag Coverage Δ
e2e 53.81% <26.38%> (+0.86%) ⬆️
unit 70.32% <71.42%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
e2e-robot — 35e9af4b Deployed Oct 30, 2026 by lukasmetzner via e2e robot #1770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant