Skip to content

feat(exp): add generic deprecationutil.Message helper - #965

Merged
jooola merged 4 commits into
mainfrom
deprecation_util_generic
Nov 5, 2026
Merged

jooola merged 4 commits into
mainfrom
deprecation_util_generic

Conversation

@jooola

@jooola jooola commented Nov 5, 2026

Copy link
Copy Markdown
Member

Most resources with deprecation do not have a complex deprecation logic as "Server Type", we can therefor refactor the helper with a generic one.

Co-authored-by: Winni Neessen <winfried.neessen@hetzner-cloud.de>
@jooola
jooola requested a review from a team as a code owner November 5, 2026 13:09
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (366a39d) to head (3372933).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   86.18%   86.16%   -0.03%     
==========================================
  Files          61       62       +1     
  Lines        4475     4468       -7     
==========================================
- Hits         3857     3850       -7     
  Misses        616      616              
  Partials        2        2              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wneessen wneessen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a simple typo, otherwise everything looks good

Comment thread hcloud/exp/deprecationutil/generic.go Resolved
@jooola
jooola requested a review from wneessen November 5, 2026 13:43
@jooola
jooola merged commit 58b701b into main Nov 5, 2026
4 checks passed
@jooola
jooola deleted the deprecation_util_generic branch November 5, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants