Fix UDPInput thread death, TCPOutput double-free, and compile warnings#62
Open
yuhengzhang-google wants to merge 3 commits into
Open
Fix UDPInput thread death, TCPOutput double-free, and compile warnings#62yuhengzhang-google wants to merge 3 commits into
yuhengzhang-google wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few critical bugs and resolves several compilation warnings to improve the stability and reusability of the LocalVPN stack.
🐛 Bug Fixes
FATAL EXCEPTIONdouble-free memory corruption inTCPOutput.java. ThecloseCleanlymethod previously released aByteBufferthat was already released in the main loop, causing pool corruption.UDPInputthread death caused by unhandledIOExceptions (such asPortUnreachableException). Thereadoperation is now wrapped in atry-catchblock so the infinite loop can safely continue instead of crashing the receiver thread.♻️ Refactoring & Warnings
TCPOutputandUDPOutputfrom the specificLocalVPNServicewrapper. Broadened the constructor signatures to accept the standard Androidandroid.net.VpnService, allowing other developers to easily reuse this networking stack in their own custom implementations.TransportProtocolenum inPacket.javaby makingprotocolNumberfinal.LRUCache.javaby adding the missing generic type parameters<K, V>toCleanupCallback.