fix: avoid unnecessary Buffer conversion for large string content#5745
Closed
quetta-1030 wants to merge 1 commit intohexojs:masterfrom
Closed
fix: avoid unnecessary Buffer conversion for large string content#5745quetta-1030 wants to merge 1 commit intohexojs:masterfrom
quetta-1030 wants to merge 1 commit intohexojs:masterfrom
Conversation
- Directly return string to avoid Buffer.from() overhead for large content - This improves performance when generating large web pages - Closes #5705
How to testgit clone -b fix/buffer-performance https://github.com/quetta-1030/hexo.git
cd hexo
npm install
npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes Issue #5705 - Avoid unnecessary Buffer conversion for large string content. When generating large web pages, Buffer.from( data) in the router causes performance overhead. This change directly returns the string instead of converting to Buffer, improving performance for large content.
Screenshots
(N/A - performance improvement)
Pull request tasks