Final adjustments for dynamic staging#461
Draft
ChingLongTin wants to merge 822 commits into
Hidden character warning
The head ref may contain hidden characters: "final\ud83d\udc24"
Draft
Conversation
…ngLongTin/mlscript into instrument-with-pretty-print
This reverts commit b8570ac.
…for easier debugging in this branch
This reverts commit 226c068. We can dynamically select the instrumented functions if needed, no need to create a compiler flag.
the parameter names of the class are not used at all, for `class B(x)`, a match case of `if B(1) is B(y)` never assigns to a variable `x`.
it has been superceded by symbolMap
This reverts commit dcc22f7.
this change is due to the normalization of ClassParamFlattener giving a parameter list for originally parameter-less classes
they will be reprinted, so they do not need to be redirected
LPTK
reviewed
May 30, 2026
| case c: ClassSymbol if c.defn.exists(defn => defn.owner.isEmpty && defn.hasStagedModifier.isDefined) => false | ||
| // avoid name collision | ||
| case _: TempSymbol | _: VarSymbol | _: BaseTypeSymbol => true | ||
| case _: TempSymbol | _: VarSymbol | _: BaseTypeSymbol => true |
Contributor
There was a problem hiding this comment.
This indent seems accidental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the changes here will be covered by a future merge of the
shapebranch.