Fix all Scala warnings in HKMC2#503
Draft
Derppening wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most warnings are mechanically addressable by either using alternative paradigms or removing redundant code.
The parts of this PR which require more scrutiny are:
@uncheckedto match arms, which may require more scrutiny since these will not be caught at runtimeshowPlain), (b) adding aTODO(...), or (c) adding alastWordsor equivalent - Whether my additions are appropriate needs to be looked into.Most difftests are unchanged - Some
MatchErrors are changed into actual compilation errors.