Skip to content

Fix all Scala warnings in HKMC2#503

Draft
Derppening wants to merge 8 commits into
hkust-taco:hkmc2from
Derppening:misc/fix-scala-warnings
Draft

Fix all Scala warnings in HKMC2#503
Derppening wants to merge 8 commits into
hkust-taco:hkmc2from
Derppening:misc/fix-scala-warnings

Conversation

@Derppening
Copy link
Copy Markdown
Contributor

Most warnings are mechanically addressable by either using alternative paradigms or removing redundant code.

The parts of this PR which require more scrutiny are:

  • 90d09f5: Adding @unchecked to match arms, which may require more scrutiny since these will not be caught at runtime
  • ab1ea34: Implement missing match arms by either (a) adding the appropriate logic (e.g. in showPlain), (b) adding a TODO(...), or (c) adding a lastWords or equivalent - Whether my additions are appropriate needs to be looked into.

Most difftests are unchanged - Some MatchErrors are changed into actual compilation errors.

@Derppening Derppening requested a review from LPTK May 27, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant