FACT-2478 audit controller #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 14, 2025 10:38
josh-uk
requested changes
Nov 18, 2025
src/main/java/uk/gov/hmcts/reform/fact/data/api/services/AuditService.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/reform/fact/data/api/services/AuditService.java
Outdated
Show resolved
Hide resolved
added 4 commits
November 18, 2025 11:20
This ensures that in the very odd edge-case where we've somehow deleted the court or the user record prior to removal of the audit, the audit records returned still refer to the internal ids that were potentially used to filter.
This is done to ensure that during integration testing, configuration is only changed from the production setup where necessary to avoid invalidating test results.
josh-uk
previously approved these changes
Nov 18, 2025
|
josh-uk
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
FACT-2478
Change description
Tests are in place for the currently merged entities (Court, CourtTranslation and CourtPhoto). Tests for other entities will need to be created.
Does this PR require manual testing? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")