Test/make snapshot more robust - #856
Merged
Merged
Conversation
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 7, 2026 04:56
4e1dc7c to
0078110
Compare
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
2 times, most recently
from
April 9, 2026 15:05
42cdd86 to
31063f4
Compare
xuantho573
approved these changes
Apr 10, 2026
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 11, 2026 02:16
51573b6 to
50cdd1d
Compare
…plicate error wording
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 14, 2026 02:27
7be64ac to
fe6fa28
Compare
This reverts commit 109c30c.
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 14, 2026 04:27
ed775e3 to
4c6b1e9
Compare
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 14, 2026 07:19
4c6b1e9 to
3c13735
Compare
huydo862003
force-pushed
the
test/make-snapshot-more-robust
branch
from
April 14, 2026 07:38
c079d6d to
c3ba691
Compare
huydo862003
added
the
PR: Internal 🏡
Coverage ReportCommit: 7a5e1da Overall Coverage
Package Coverage
|
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/connectors/bigquery/index.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/credential-loader.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/helpers.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/connectors/snowflake/index.ts |
10.56% | 10.31% | 0.00% | 0.00% |
src/utils/parseSchema.ts |
46.15% | 42.85% | 28.57% | 27.27% |
src/connectors/connector.ts |
66.66% | 66.66% | 100.00% | 57.14% |
src/connectors/oracle/tables.ts |
71.25% | 67.39% | 100.00% | 56.96% |
src/connectors/oracle/index.ts |
80.00% | 80.76% | 100.00% | 25.00% |
src/connectors/oracle/utils.ts |
85.71% | 85.71% | 100.00% | 71.42% |
@dbml/dbml-parse
47 file(s) below 80% coverage
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/compiler/queries/container/scope.ts |
0.00% | 0.00% | 0.00% | 100.00% |
src/core/types/internable.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/services/diagnostics/provider.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/core/types/symbol/utils.ts |
6.89% | 6.89% | 66.66% | 0.00% |
src/core/utils/span.ts |
14.28% | 14.28% | 33.33% | 16.66% |
src/core/types/filepath.ts |
25.00% | 23.33% | 41.17% | 8.33% |
src/core/types/report.ts |
50.00% | 44.44% | 58.33% | 42.85% |
src/core/interpreter/elementInterpreter/project.ts |
51.42% | 51.42% | 100.00% | 36.36% |
src/core/analyzer/binder/elementBinder/enum.ts |
55.55% | 57.89% | 83.33% | 37.50% |
src/core/interpreter/records/utils/data/sqlTypes.ts |
56.25% | 58.82% | 75.00% | 46.55% |
src/core/analyzer/binder/elementBinder/note.ts |
62.50% | 64.70% | 83.33% | 50.00% |
src/core/analyzer/binder/elementBinder/diagramView.ts |
64.47% | 65.85% | 76.00% | 51.51% |
src/compiler/queries/utils.ts |
64.83% | 65.95% | 88.88% | 47.43% |
src/core/interpreter/records/utils/data/values.ts |
65.13% | 57.14% | 72.72% | 50.71% |
src/compiler/queries/legacy/parse.ts |
66.66% | 66.66% | 66.66% | 100.00% |
src/compiler/queries/legacy/token.ts |
66.66% | 66.66% | 66.66% | 100.00% |
src/core/analyzer/validator/elementValidators/indexes.ts |
71.42% | 72.28% | 90.90% | 57.40% |
src/core/parser/utils.ts |
73.58% | 74.23% | 100.00% | 81.50% |
src/core/types/symbol/symbolIndex.ts |
73.91% | 74.46% | 93.75% | 42.85% |
src/core/analyzer/validator/elementValidators/note.ts |
74.54% | 72.88% | 76.92% | 72.22% |
src/core/analyzer/analyzer.ts |
75.00% | 66.66% | 60.00% | 100.00% |
src/core/analyzer/validator/elementValidators/project.ts |
76.47% | 77.14% | 100.00% | 55.55% |
src/core/analyzer/utils.ts |
76.69% | 75.23% | 87.50% | 72.52% |
src/core/analyzer/validator/elementValidators/checks.ts |
76.78% | 78.33% | 93.75% | 70.58% |
src/core/analyzer/validator/elementValidators/records.ts |
77.02% | 77.63% | 93.75% | 73.43% |
src/core/analyzer/binder/elementBinder/project.ts |
77.77% | 78.94% | 100.00% | 50.00% |
src/core/analyzer/binder/elementBinder/ref.ts |
78.78% | 80.00% | 90.90% | 75.00% |
src/core/analyzer/binder/elementBinder/indexes.ts |
79.54% | 78.26% | 90.90% | 70.83% |
src/core/analyzer/binder/elementBinder/tableGroup.ts |
80.00% | 80.64% | 100.00% | 50.00% |
src/compiler/queries/transform/syncDiagramView.ts |
80.43% | 73.83% | 75.00% | 68.75% |
src/core/interpreter/records/utils/constraints/pk.ts |
82.00% | 81.53% | 92.30% | 59.09% |
src/services/suggestions/utils.ts |
82.35% | 76.78% | 92.85% | 68.96% |
src/core/analyzer/binder/elementBinder/records.ts |
82.60% | 83.15% | 93.75% | 68.00% |
src/core/analyzer/validator/elementValidators/tablePartial.ts |
82.75% | 80.41% | 87.23% | 63.75% |
src/compiler/queries/container/token.ts |
83.33% | 85.71% | 100.00% | 75.00% |
src/core/analyzer/validator/elementValidators/enum.ts |
84.09% | 82.60% | 84.21% | 79.16% |
src/core/analyzer/validator/elementValidators/diagramView.ts |
84.69% | 80.95% | 85.00% | 72.00% |
src/core/parser/parser.ts |
84.95% | 85.12% | 98.07% | 77.77% |
src/core/analyzer/binder/elementBinder/tablePartial.ts |
86.00% | 86.53% | 100.00% | 69.23% |
src/core/interpreter/elementInterpreter/diagramView.ts |
86.17% | 84.90% | 70.00% | 67.07% |
src/core/types/nodes.ts |
88.05% | 87.68% | 86.11% | 72.13% |
src/services/suggestions/recordRowSnippet.ts |
88.46% | 84.37% | 100.00% | 78.00% |
src/compiler/queries/legacy/symbol.ts |
91.66% | 92.00% | 100.00% | 78.57% |
__tests__/utils/compiler.ts |
93.26% | 92.95% | 100.00% | 69.14% |
src/core/interpreter/elementInterpreter/sticky_note.ts |
95.00% | 95.23% | 100.00% | 66.66% |
src/core/types/symbol/symbolTable.ts |
100.00% | 100.00% | 100.00% | 75.00% |
src/services/definition/provider.ts |
100.00% | 100.00% | 100.00% | 75.00% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-> Every time we support some more nodes or trivially modify parsing logic/validation logic -> Node and symbol ids get changed
-> The snapshots change a lot
-> This make verification of real behavior changes difficult & tedious.
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done