Skip to content

Conversation

@jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Sep 25, 2025

Proposed change

Integrations that want to be able to poll the state via MQTT when the integration starts, like Tasmota, need to be sure an MQTT subscription has been processed, before it can publish a ready state.

This PR allows allows to set a callback function when calling async_subscribe that is called when the subscription is done at the broker.

A second helper async_on_subscribe_done will allow to monitor subscriptions via a callback function. This helper will keep listening till the return callback handler is called.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery
Copy link
Contributor

Setting to draft while discussing the solution on Discord

@jbouwh jbouwh force-pushed the mqtt-subscribe-wait-option branch from 79738cf to 55ec8d2 Compare October 6, 2025 19:09
@jbouwh jbouwh force-pushed the mqtt-subscribe-wait-option branch from 55ec8d2 to aabcff9 Compare October 8, 2025 17:30
@jbouwh jbouwh marked this pull request as ready for review October 8, 2025 17:31
@jbouwh jbouwh changed the title Allow to wait for MQTT subscription Allow to callback for MQTT subscription status Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants