Generic picker: show a label for area, category, language #28236
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Co-authored-by: Aidan Timson <[email protected]>
Co-authored-by: Aidan Timson <[email protected]>
Member
|
This is great, thanks @ildar170975 🚀 |
Contributor
Author
|
Guys, thanks a lot for support |
timmo001
requested changes
Dec 3, 2025
|
|
||
| const valueRenderer = this._computeValueRenderer(this.hass.areas); | ||
|
|
||
| let showLabel; |
Member
There was a problem hiding this comment.
Suggested change
| let showLabel; | |
| let showLabel = this.showLabel; |
Comment on lines
+370
to
+375
| const area_id = this.value; | ||
| const area = this.hass.areas[area_id]; | ||
| const { floor } = getAreaContext(area, this.hass.floors); | ||
| showLabel = floor ? false : this.showLabel; | ||
| } else { | ||
| showLabel = this.showLabel; |
Member
There was a problem hiding this comment.
Suggested change
| const area_id = this.value; | |
| const area = this.hass.areas[area_id]; | |
| const { floor } = getAreaContext(area, this.hass.floors); | |
| showLabel = floor ? false : this.showLabel; | |
| } else { | |
| showLabel = this.showLabel; | |
| const area = this.hass.areas[this.value]; | |
| if (area) { | |
| const { floor } = getAreaContext(area, this.hass.floors); | |
| showLabel = !floor && this.showLabel; | |
| } |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
Author
No problem! I will do it in a few days when be near a PC. SORRY for a delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Changes were made for:
ha-language-picker:ha-category-picker- only forha-dialog-automation-save:ha-area-picker- only for:--
ha-dialog-automation-save--
entity-registry-settings-editor--
dialog-device-registry-detailNote that for
ha-area-pickera label is only shown when a floor is not displayed (to prevent a clutter).In
ha-combo-box-item, styles were defined foroverlineslot to mimic (as possible) a floating label inmdc-select.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: