Skip to content

Conversation

@silamon
Copy link
Contributor

@silamon silamon commented Dec 2, 2025

Proposed change

From @marcinbauer85
I see some issues in how this was implemented.
image

If we have a togglable action in the context menu we should use icons for both states. Since this is just an enabled/disabled state let's use mdi:checkbox-marked and mdi:checkbox-blank-outline
The last item in this list "Join beta channel" icon: mdi:location-enter, "Leave beta channel" icon: mdi:location-exit


We may need to patch the checkbox icons as well, since an unchecked state is just nothing in webawesome. If we use icons to show checked state (like how I quickly did it here), we'll lose the accessibility.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon added this to the 2025.12 milestone Dec 2, 2025
@wendevlin wendevlin self-assigned this Dec 3, 2025
@wendevlin
Copy link
Member

I get what you mean. It should stay type checkbox and use the checked attribute. I'll have a look on how to adopt WA

@wendevlin wendevlin removed this from the 2025.12 milestone Dec 3, 2025
@wendevlin wendevlin marked this pull request as draft December 3, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants