Skip to content

feat(oauth-providers): Pass optional state as parameter, so we can link other state info to it #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mansimransingh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(oauth-providers): Pass optional state as parameter, so we can link other state info to it #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-pandas-talk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hono/oauth-providers': minor
---

Optionally pass state as an option to oauth provider
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/discord/discordAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ export function discordAuth(options: {
client_id?: string
client_secret?: string
redirect_uri?: string
state?: string
}): MiddlewareHandler {
return async (c, next) => {
// Generate encoded "keys"
const newState = getRandomState()
const newState = options.state || getRandomState()

// Create new Auth instance
const auth = new AuthFlow({
Expand Down
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/facebook/facebookAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ export function facebookAuth(options: {
client_id?: string
client_secret?: string
redirect_uri?: string
state?: string
}): MiddlewareHandler {
return async (c, next) => {
const newState = getRandomState()
const newState = options.state || getRandomState()
// Create new Auth instance
const auth = new AuthFlow({
client_id: options.client_id || (env(c).FACEBOOK_ID as string),
Expand Down
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/github/githubAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ export function githubAuth(options: {
scope?: GitHubScope[]
oauthApp?: boolean
redirect_uri?: string
state?: string
}): MiddlewareHandler {
return async (c, next) => {
const newState = getRandomState()
const newState = options.state || getRandomState()
// Create new Auth instance
const auth = new AuthFlow({
client_id: options.client_id || (env(c).GITHUB_ID as string),
Expand Down
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/linkedin/linkedinAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ export function linkedinAuth(options: {
scope?: LinkedInScope[]
appAuth?: boolean
redirect_uri?: string
state?: string
}): MiddlewareHandler {
return async (c, next) => {
const newState = getRandomState()
const newState = options.state || getRandomState()
// Create new Auth instance
const auth = new AuthFlow({
client_id: options.client_id || (env(c).LINKEDIN_ID as string),
Expand Down
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/x/xAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ export function xAuth(options: {
client_id?: string
client_secret?: string
redirect_uri?: string
state?: string
}): MiddlewareHandler {
return async (c, next) => {
// Generate encoded "keys"
const newState = getRandomState()
const newState = options.state || getRandomState()
const challenge = await getCodeChallenge()

const auth = new AuthFlow({
Expand Down