Skip to content

Conversation

@GordonSmith
Copy link
Member

No description provided.

@GordonSmith GordonSmith changed the base branch from master to 0.3 July 8, 2025 09:37
@GordonSmith GordonSmith changed the base branch from 0.3 to master July 8, 2025 09:37
@GordonSmith GordonSmith requested a review from Copilot July 8, 2025 09:38

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates numerous modules to use named function expressions and explicit this.inherited calls, laying groundwork for strict mode compatibility.

  • Added function names to method expressions for all widget extension methods.
  • Updated all this.inherited(arguments) calls to this.inherited(<methodName>, arguments) (or with explicit arg arrays).
  • Ensured consistency across core grid, list, tree, and extension files.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
extensions/SingleQuery.js Named refresh and renderArray, updated this.inherited.
extensions/Pagination.js Named lifecycle methods and pagination handlers.
extensions/DnD.js Named drag-and-drop hooks, updated inherited calls.
extensions/DijitRegistry.js Named widget lifecycle methods, consistent inherited usage.
extensions/CompoundColumns.js Named column mixin methods, updated inherited usages.
extensions/ColumnResizer.js Named render/layout methods, updated inherited calls.
extensions/ColumnReorder.js Named DnD override methods, updated inherited calls.
extensions/ColumnHider.js Named header/navigation methods, updated inherited calls.
_StoreMixin.js Named store mixin methods, updated inherited calls.
Tree.js Named tree-specific overrides, updated inherited calls.
Selector.js Named selector lifecycle methods, updated inherited calls.
Selection.js Named selection lifecycle methods, updated inherited calls.
OnDemandList.js Named rendering/lifecycle methods, updated inherited calls.
List.js Named startup, updated inherited call.
Keyboard.js Named keyboard methods, updated inherited calls.
GridWithColumnSetsFromHtml.js Named configStructure, updated inherited calls.
GridFromHtml.js Named methods for config and create, updated inherited.
Grid.js Named resize/destroy/sort methods, updated inherited calls.
Editor.js Named editor lifecycle methods, updated inherited calls.
ColumnSet.js Named column set mixin methods, updated inherited calls.
CellSelection.js Named cell selection methods, updated inherited calls.
Comments suppressed due to low confidence (1)

extensions/SingleQuery.js:1

  • To fully enforce strict mode, add a 'use strict'; directive at the start of the module function body (immediately after the define callback).
define([

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant