fix(chat): use lucide/settings-2 icon for settings#2300
Open
LoneRifle wants to merge 1 commit into
Open
Conversation
LoneRifle
force-pushed
the
fix/chat/model-settings
branch
5 times, most recently
from
146fb26 to
be86f4b
Compare
LoneRifle
force-pushed
the
fix/chat/model-settings
branch
2 times, most recently
from
7be57dc to
680ac25
Compare
The icon next to the current model indicator in chat is associated with dropdowns, intuitively a hint to the user that the model can be changed for the conversation. This is not the case, and actually brings up the settings modal. Change this to `lucide/settings-2`, given its similarity to the controls in the settings modal.
LoneRifle
force-pushed
the
fix/chat/model-settings
branch
from
680ac25 to
3937f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The icon next to the current model indicator in chat is associated with dropdowns, intuitively a hint to the user that the model can be changed for the conversation. This is not the case, and actually brings up the settings modal.
Solution
Change this to
lucide/settings-2, given its similarity to the controls in the settings modal.Screenshots
Before
Per #2296
After