Skip to content

Conversation

@ishan-modi
Copy link
Contributor

What does this PR do?

Fixes #11002

Who can review?

@DN6 @yiyixuxu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ishan-modi
Copy link
Contributor Author

@DN6, gentle ping

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I left some questions on how we should determine default

scheduler: KarrasDiffusionSchedulers,
):
super().__init__()
self._guidance_scale = 1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest:

1 .default _guidance_scale to be same as each pipeline call default, e.g. 7.5 here

2 _num_stesps can be None here since it is not yet known

but let me know all your thoughts @DN6 @ishan-modi

@yiyixuxu yiyixuxu requested a review from DN6 June 16, 2025 19:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 9, 2026
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Jan 9, 2026
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jan 9, 2026

hi @ishan-modi
are you still available on working on this? if not, we can open this to the community as well

let me know!

@ishan-modi
Copy link
Contributor Author

Hi @yiyixuxu, thanks for reviving this MR, as requested I have updated guidance_scale in __init__ to match __call__ defaults

let me know if you think it requires any other change

@ishan-modi ishan-modi requested a review from yiyixuxu January 11, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any chance class members like self._interrupt could be defined in __init__ across pipelines?

3 participants