-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[Refactor] Initialize class members inside init method #11450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…fusers into fixes-issue-11002
|
@DN6, gentle ping |
yiyixuxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I left some questions on how we should determine default
| scheduler: KarrasDiffusionSchedulers, | ||
| ): | ||
| super().__init__() | ||
| self._guidance_scale = 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would suggest:
1 .default _guidance_scale to be same as each pipeline call default, e.g. 7.5 here
2 _num_stesps can be None here since it is not yet known
but let me know all your thoughts @DN6 @ishan-modi
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
hi @ishan-modi let me know! |
|
Hi @yiyixuxu, thanks for reviving this MR, as requested I have updated guidance_scale in let me know if you think it requires any other change |
What does this PR do?
Fixes #11002
Who can review?
@DN6 @yiyixuxu