[GLM-Image] New Models Support #12921
Closed
+1,913
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
reviewed
Jan 7, 2026
yiyixuxu
reviewed
Jan 8, 2026
zRzRzRzRzRzRzR
changed the title
sayakpaul
reviewed
Jan 8, 2026
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Looking quite good!
I think all the precomputations are in place and the use of caching also reads quite simple.
Member
|
@bot /style |
Contributor
|
Style fix is beginning .... View the workflow run here. |
yiyixuxu
reviewed
Jan 13, 2026
version guard glm image pipeline
validate prompt_embeds and prior_token_ids
72 tasks
Skip tests where relevant
skip tests properly and fix more
attempt at fixing the import problems in the CI
Contributor
Author
|
Using as #12973 , merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yiyixuxu @sayakpaul For check with model