Conversation
Travor278
marked this pull request as ready for review
April 6, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the worker-sharding bug from #200.
When
VQADataset.iter_for_worker()was used with a streaming dataset andDataLoader(num_workers > 1), each worker would walk the full stream independently. That meant every sample was processed once per worker instead of once overall.What changed:
.shard(...)when the underlying dataset supports it.shard()Why this matters:
Validation:
D:\Dev\conda-envs\py313\python.exe -m unittest tests.test_worker_sharding -vD:\Dev\conda-envs\py313\python.exe tests\benchmark_worker_sharding.py --workers 4 --samples 2000 --repeats 540000processed /10000unique /30000duplicates /554.33effective samples/s10000processed /10000unique /0duplicates /900.49effective samples/sD:\Dev\conda-envs\py313\python.exe tests\smoke_worker_sharding_train_path.py --device auto288total /96unique /192duplicates /3.00x96total /96unique /0duplicates /1.00xFixes #200.