Align KTO with DPO: Fix KTO compute_metrics type hint (EvalLoopOutput → EvalPrediction)#6253
Merged
Merged
Conversation
compute_metrics type hint (EvalLoopOutput → EvalPrediction)compute_metrics type hint (EvalLoopOutput → EvalPrediction)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the effort to align
KTOTrainer(experimental) withDPOTrainer. #4786KTOTrainer.__init__typedcompute_metricsasCallable[[EvalLoopOutput], dict], which was both wrong (the Trainer passes anEvalPredictiontocompute_metrics, not anEvalLoopOutput) and inconsistent with the trainer's own docstring, which already documents it asEvalPrediction. Switched the annotation and the import toEvalPrediction, matchingDPOTrainer.No behavior change (type-annotation only).
Note
Low Risk
Type-annotation-only change in experimental KTO trainer; no logic, data, or API behavior is modified.
Overview
Aligns experimental
KTOTrainerwithDPOTrainerby correcting thecompute_metricstyping only.The import and
__init__annotation now useEvalPredictioninstead ofEvalLoopOutput, matching what Hugging FaceTraineractually passes intocompute_metricsand what the class docstring already described. No runtime or training behavior changes.Reviewed by Cursor Bugbot for commit 35a7703. Bugbot is set up for automated code reviews on this repo. Configure here.