Align KTO with DPO: Log entropy metric#6257
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the effort to align
KTOTrainer(experimental) withDPOTrainer. #4786DPOTrainerlogs anentropymetric (mean per-token predictive entropy over completion tokens);KTOTrainerdid not. Added it for parity, using the same token-weighted cross-rank averaging as DPO:entropy_from_logitsfromtrl.trainer.utils._compute_loss, compute per-token entropy over the completion tokens (completion_mask), gather sums and token counts across ranks, and log the weighted mean asentropy.Only added to
_compute_loss, not_compute_loss_liger: the Liger path does not materialize logits, so entropy cannot be computed there (same as DPO).No change to the loss or existing metrics.
Note
Low Risk
Observability-only metrics logging reusing the same helper and aggregation pattern as DPO; no loss or training logic changes.
Overview
Experimental
KTOTrainernow logs mean per-token predictive entropy over completion tokens, matchingDPOTrainerbehavior for alignment work (#4786).The change imports
entropy_from_logitsand, in_compute_loss, computes entropy from detachedshift_logits, masks withcompletion_mask[:, 1:], and records a token-weighted mean aftergather_for_metricsacross ranks under theentropymetric key. KTO loss and existing metrics are unchanged.Entropy is not added on the Liger path (
_compute_loss_liger), because logits are not materialized there—same limitation as DPO.Reviewed by Cursor Bugbot for commit 2fdb24f. Bugbot is set up for automated code reviews on this repo. Configure here.