excretion parameters ERTLST, ERTMAX (reimplementation of #475)#513
Draft
Gero1999 wants to merge 1 commit intohumanpred:mainfrom
Draft
excretion parameters ERTLST, ERTMAX (reimplementation of #475)#513Gero1999 wants to merge 1 commit intohumanpred:mainfrom
Gero1999 wants to merge 1 commit intohumanpred:mainfrom
Conversation
… (still needs fixing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR re-introduces the excretion rate parameters: the maximum excretion rate (
ermax), the time of maximum excretion rate (ertmax), and the time of the last measurable excretion rate (ertlst). It also adds supporting infrastructure for these parameters, such as new unit types, helper functions for missing data messages, and comprehensive tests. Additionally, some code cleanup and improvements to missing data handling are included.The purpose is to keep working in this PR to solve the invisible issues that happened after merging #475 related with:
allow.tmaxforertmaxparameters. Perhaps the appropiate would be to create a new arg that by default is the same asallow.tmax(@billdenney ?)pk.nca(test already implemented inmain)