Skip to content

Conversation

@beefancohen
Copy link
Contributor

Fixes #206

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: 4d252a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/node-opentelemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brandon-pereira
Copy link
Member

@wrn14897 I tested this locally and I see the OTEL_EXPORTER_OTLP_HEADERS headers being passed to the health check endpoint. I also added tests to help cover this case. Would love a second review on this if possible though!

@beefancohen
Copy link
Contributor Author

@wrn14897 I tested this locally and I see the OTEL_EXPORTER_OTLP_HEADERS headers being passed to the health check endpoint. I also added tests to help cover this case. Would love a second review on this if possible though!

thanks for adding tests, i wasn't sure if we wanted to export the helper fn

@brandon-pereira
Copy link
Member

@wrn14897 I tested this locally and I see the OTEL_EXPORTER_OTLP_HEADERS headers being passed to the health check endpoint. I also added tests to help cover this case. Would love a second review on this if possible though!

thanks for adding tests, i wasn't sure if we wanted to export the helper fn

Good point.. I moved the function to the utils folder :)

@brandon-pereira brandon-pereira self-requested a review November 20, 2025 21:00
@brandon-pereira
Copy link
Member

@beefancohen We will ship this in the next release - if you need it sooner, please let us know, and we can publish a patch version.

Thanks again for helping us improve the SDK! We really appreciate your input.

Copy link
Member

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@brandon-pereira brandon-pereira merged commit 4ad6c88 into hyperdxio:main Nov 20, 2025
3 checks passed
@beefancohen
Copy link
Contributor Author

@beefancohen We will ship this in the next release - if you need it sooner, please let us know, and we can publish a patch version.

Thanks again for helping us improve the SDK! We really appreciate your input.

No rush it's not affecting any runtime behavior was just confusing me at first!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Health checks do not pass authorization headers

3 participants