ci: put the required-context entry criteria where a person will meet them - #1092
Merged
Conversation
…them The four measured criteria for making the differential verdict a required status check were only in the run summary that nix/ci/delta-gate.sh renders. That summary is read when the pipeline runs, and every trigger has been workflow_dispatch since #1088, so in practice nobody meets them. They move to the header of nix/ci/flake-gate.nix, which is the file anybody asking "why does this not block anything" opens first. The summary keeps the one-line statement that the verdict blocks nothing and points at the header rather than restating the criteria, so there is one copy to keep true. No behaviour change: comments and one summary paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1090.
The four measured criteria for making the differential verdict a required status check were only in the summary
nix/ci/delta-gate.shrenders. That summary is read when the pipeline runs, and every trigger has beenworkflow_dispatchsince #1088, so nobody meets them.They move into the header of
nix/ci/flake-gate.nix, which is the file anybody asking "why does this not block anything" opens first. Each criterion carries its measured value and why the number is what it is:grouping_strategy: ALLGREENwithmax_entries_to_build: 5means a flake ejects a batch of up to five pull requests rather than costing one author a re-run.The summary keeps the one-line statement that the verdict blocks nothing, plus ENG-10827, and points at the header instead of restating the criteria. One copy to keep true.
No behaviour change: comments plus one summary paragraph.
checks.<system>.delta-gatestill passes 65 of 65 in the sandbox,checks.<system>.flake-gatebuilds,nix run .#fmtclean.Refs ENG-11433, ENG-10827.