engine_getBlobsV2 parallel serialization of blob data #9413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proofs Signed-off-by: Simon Dudley <[email protected]>
siladu
force-pushed
the
engineGetBlobsV2-parallel-serialize
branch
from
2585b21 to
fabc421
Compare
Contributor
Author
|
Closing in favour of #9445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates scalability issues since converting blob data toHexString is O(n).
Blob proofs are still processed in serial stream within each blob processing thread. The proofs contain less data so probably aren't the bottleneck and parallelising this may add more overhead than it's worth.
Testing this out alongside the parallel proof version: #9414