Add apiServerApiKey to VertxConfig.java utility #28
Open
thechibuikem wants to merge 1 commit into
Open
Conversation
Reads apiServer.apiKey from CONFIG, used by apis-web's authentication check Signed-off-by: Chukwuemeka David <david.chukwuemeka.swe@gmail.com>
thechibuikem
changed the title
FlawzyByte
reviewed
Jul 10, 2026
FlawzyByte
left a comment
FlawzyByte
left a comment
Member
There was a problem hiding this comment.
Good catch david, extending the mechanism of apis-web
LGTM!
Member
|
@subhramit |
subhramit
requested changes
Jul 10, 2026
Comment on lines
+96
to
+98
| public static String apiServerApiKey(){ | ||
| return config.getString("apiServer","apiKey") | ||
| } |
Member
There was a problem hiding this comment.
Please fix the formatting a bit - see how the other methods are formatted.
- javadoc indentation
- space before opening curly brace, indent of closing curly brace
- Comma before the second getString param
- Henceforth we don't need to include chinese javadoc comments as now the project is maintained by us.
To make at least 1, 2, 3 a part of automated CI checks, and also integrate into IDE, we can introduce Checkstyle eventually (cc @FlawzyByte).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to hyphae/apis-web/pull/13
Reads apiServer.apiKey from CONFIG, used by apis-web's authentication check