Add versioning support to annotation creation/editing and search#7518
Draft
karenrasmussen wants to merge 1 commit intomainfrom
Draft
Add versioning support to annotation creation/editing and search#7518karenrasmussen wants to merge 1 commit intomainfrom
karenrasmussen wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (48.57%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7518 +/- ##
==========================================
- Coverage 99.61% 99.46% -0.15%
==========================================
Files 283 283
Lines 11877 11914 +37
Branches 2898 2908 +10
==========================================
+ Hits 11831 11850 +19
- Misses 46 64 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for extracting and handling document version information in the metadata processing and frame URI generation logic. The main changes involve parsing version numbers from specific metadata fields, storing this version in the document metadata, and incorporating it into the generated URIs for frames.
Metadata version extraction and propagation:
versionfield to theHTMLDocumentMetadataandDocumentMetadatatypes to store the document version if detected. [1] [2]HTMLMetadataclass to extract a version number fromhighwire.id,highwire.public_url, and the canonical link, ensuring all three sources agree on the version (must end with v1–v25).Frame URI handling:
searchUrisForFramefunction to append the version information to each URI in the format:v0:v{version}if a version is present in the frame's metadata.