Albedo decay based on burn mask in topo.nc
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomey
force-pushed
the
albedo_burn_decay
branch
from
79eeafb to
a11b521
Compare
caldwellng
approved these changes
Oct 9, 2025
jomey
force-pushed
the
albedo_burn_decay
branch
3 times, most recently
from
f45c8f1 to
d2c388f
Compare
jomey
force-pushed
the
albedo_burn_decay
branch
3 times, most recently
from
39165b1 to
254a883
Compare
Rename the parameters to define a decay window and move the function to determine whether the window is present to the distribute class for re-use. This prepares add a new post fire based decay method that should also be triggered within the same time window. The config parameters are now: * start_decay (formerly date_method_start_decay) * end_decay (formerly date_method_end_decay)
Adds reading in a new layer that defines a burn mask on the topo file.
Add a new option to decay albedo based on a burn mask in the topo file and configured values in the .ini via `post_fire_k_burned` and `post_fire_k_unburned`. The method itself will be triggered via the decay method `post_fire`. Co-authored-by: caldwellng <[email protected]>
* Fix type hint for `last_snow` parameter; it's an array * Improve output initialization and use empty values * Rename exponential variables that conflicted with method name
Change the names to configure dates to `decay_start` and `decay_end` to be consistent with the main parameter name `decay_method`.
The main branch had an overhaul of the init method, changing a few pieces of the logic in this branch with was developed in parallel. This now also adds the accessor to veg_type from the topo with the ImageData base class.
jomey
force-pushed
the
albedo_burn_decay
branch
from
460946a to
5cad9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
NOTE
Once merged - all configuration
.inifiles will need to update their parameter for time decay window.Renamed parameters in
[albedo]section