Conversation
Bumps [pg](https://github.com/brianc/node-postgres/tree/HEAD/packages/pg) from 8.18.0 to 8.20.0. - [Changelog](https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md) - [Commits](https://github.com/brianc/node-postgres/commits/pg@8.20.0/packages/pg) --- updated-dependencies: - dependency-name: pg dependency-version: 8.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
bri-tong
left a comment
There was a problem hiding this comment.
Code Review: Bump pg from 8.18.0 to 8.20.0
Summary
This is a Dependabot minor version bump of the pg (node-postgres) package from 8.18.0 to 8.20.0. The change touches only server/package.json (version specifier) and package-lock.json (resolved versions and regenerated metadata). The upgrade is low-risk — the codebase uses only standard Pool and pool.query()/client.query() APIs, all of which are stable and unchanged in this release.
Blocking Issues
None.
Non-blocking Suggestions
-
Lockfile metadata drift: The regenerated
package-lock.jsonintroduces several fields beyond thepgbump —license: "MIT"entries andengines: { "node": ">=18.0.0" }blocks in root, client, and server workspace entries. This is expected Dependabot behavior (it runsnpm installwhich picks up metadata from workspacepackage.jsonfiles), but it's worth noting these are cosmetic lockfile changes, not behavioral ones. -
Deprecation awareness (pg 8.19.0): pg 8.19.0 deprecated the internal client query queue, meaning calling
client.query()multiple times without awaiting the previous call will now emit a deprecation warning. I verified that allclient.query()calls in this codebase are properlyawaited (server/src/db/migrate.js,server/src/models/tournamentTeam.model.js,server/src/services/bestBall.service.js), so this deprecation does not affect you. -
Version specifier change: The
server/package.jsonspecifier changed from"^8.11.3"to"^8.20.0", which raises the minimum resolved version from 8.11.3 to 8.20.0 for fresh installs. This is fine since 8.x maintains backward compatibility, but it means contributors doing a freshnpm installwill never resolve to anything below 8.20.0.
Questions / Clarifications
None — this is a straightforward, well-scoped dependency update.
Verdict
✅ Safe to merge. The pg 8.18.0→8.20.0 upgrade is a minor version bump with no breaking changes. The codebase's usage patterns (Pool, pool.query(), sequential await client.query()) are fully compatible with the new version.
Bumps pg from 8.18.0 to 8.20.0.
Changelog
Sourced from pg's changelog.
Commits
c9070ccPublishad36e3cfix: typo in deprecation notice forclient.query()(#3618)f2d7d11Publish5a4bafcDeprecate Client's internal query queue (#3603)a215bfbTypo fix in PgPass deprecation (funciton) (#3605)01e0556fix(pg-query-stream): invokethis.callbackon cursor end/error (#2810)e6e3692Pass connection parameters to password callback (#3602)d80d883test: Fix TLS connection test ending too earlyf332f28fix: Connection timeout handling for native clients in connected state (#3512)b2e9cb1Remove testAsync - its redundant (#3588)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)