Repository navigation
feat: warn the PR early when its build crashes, and mark failures other PRs share - #5
Merged
Merged
Conversation
…er PRs share While the suite runs, the central run now publishes live.json (counts and the top browser-side cause so far). The poll loop reads it every two minutes from tests.iblai.app, logs a progress line, and posts one early-warning comment once a crash or browser error has hit 10 tests; the run keeps going. /status shows the same live counts. In the comment, a cause other PRs' recent runs hit too is marked "also failing on …, probably not yours", and the code quote and the dependency hint follow this PR's own top cause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Change
Early warning:
While the run executes, the poll loop fetches the central run's
live.jsonfrom tests.iblai.app every 2 minutes. That's a CloudFront request, so no GitHub API budget.It logs
e2e progress: 298 passed, 74 failed so far; most common: App crash x35TypeError: …``.Once a crash or browser error has hit 10 tests, it posts one comment and the run keeps going:
Symptoms and server errors never trigger it, and a
live.jsonthat isn't published yet is not an error. Nothing in this path can fail the step, which runs underbash -e./statusadds the same live counts to "Running now".Shared causes: a cause other PRs' runs hit in the last 48 h shows as "— also failing on os#610, probably not yours". The code quote and the dependency hint follow the PR's own top cause. With nothing of its own, there is no hint.
README: "Reading your PR e2e result" explains the causes, the "also failing" mark and the early warning.
Testing
tests/test-render.py: 63 cases, 15 of them new:--liveCLI writing the warning only when due, and tolerating a missing file;render.py, all caught.check_livefromaction.yml, extracted and run underbash -ewith stubbedcurl/gh:…/runs/pr-os-617-41060344848/mentor/live.json;🤖 Generated with Claude Code